Compare commits

...

3 commits

Author SHA1 Message Date
Benjamin Nussbaum
e9037ef5d7 fix: mashup preview for Framework v2
Some checks failed
tests / ci (push) Has been cancelled
2025-09-19 17:33:00 +02:00
Benjamin Nussbaum
ee9f21a83d feat: enhanced device support when rendering mashups 2025-09-19 17:04:23 +02:00
Benjamin Nussbaum
19a8bb18cc ci: update 2025-09-19 10:48:02 +02:00
4 changed files with 34 additions and 9 deletions

View file

@ -43,7 +43,7 @@ jobs:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
tags: |
type=ref,event=tag
type=raw,value=latest,enable=${{ github.event.release.prerelease == false }}
type=raw,value=latest,enable=${{ !github.event.release.prerelease }}
- name: Build and push Docker image
uses: docker/build-push-action@v6

View file

@ -135,10 +135,13 @@ class PlaylistItem extends Model
/**
* Render all plugins with appropriate layout
*/
public function render(): string
public function render(?Device $device = null): string
{
if (! $this->isMashup()) {
return view('trmnl-layouts.single', [
'colorDepth' => $device?->deviceModel?->color_depth,
'deviceVariant' => $device?->deviceModel?->name ?? 'og',
'scaleLevel' => $device?->deviceModel?->scale_level,
'slot' => $this->plugin instanceof Plugin
? $this->plugin->render('full', false)
: throw new Exception('Invalid plugin instance'),
@ -160,6 +163,9 @@ class PlaylistItem extends Model
}
return view('trmnl-layouts.mashup', [
'colorDepth' => $device?->deviceModel?->color_depth,
'deviceVariant' => $device?->deviceModel?->name ?? 'og',
'scaleLevel' => $device?->deviceModel?->scale_level,
'mashupLayout' => $this->getMashupLayoutType(),
'slot' => implode('', $pluginMarkups),
])->render();

View file

@ -343,12 +343,22 @@ class Plugin extends Model
}
if ($standalone) {
if ($size === 'full') {
return view('trmnl-layouts.single', [
'colorDepth' => $device?->deviceModel?->color_depth,
'deviceVariant' => $device?->deviceModel?->name ?? 'og',
'scaleLevel' => $device?->deviceModel?->scale_level,
'slot' => $renderedContent,
])->render();
} else {
return view('trmnl-layouts.mashup', [
'mashupLayout' => $this->getPreviewMashupLayoutForSize($size),
'colorDepth' => $device?->deviceModel?->color_depth,
'deviceVariant' => $device?->deviceModel?->name ?? 'og',
'scaleLevel' => $device?->deviceModel?->scale_level,
'slot' => $renderedContent,
])->render();
}
}
return $renderedContent;
@ -386,4 +396,13 @@ class Plugin extends Model
{
return $this->configuration[$key] ?? $default;
}
public function getPreviewMashupLayoutForSize(string $size): string
{
return match ($size) {
'half_vertical' => '1Lx1R',
'quadrant' => '2x2',
default => '1Tx1B',
};
}
}

View file

@ -110,7 +110,7 @@ Route::get('/display', function (Request $request) {
}
}
$markup = $playlistItem->render();
$markup = $playlistItem->render(device: $device);
GenerateScreenJob::dispatchSync($device->id, null, $markup);
$device->refresh();