refactor: apply rector

app/Services/ImageGenerationService.php

@@ -233,14 +233,14 @@ class ImageGenerationService
         if ($plugin?->id) {
             // Check if any devices have custom dimensions or use non-standard DeviceModels
             $hasCustomDimensions = Device::query()
-                ->where(function ($query) {
+                ->where(function ($query): void {
                     $query->where('width', '!=', 800)
                         ->orWhere('height', '!=', 480)
                         ->orWhere('rotate', '!=', 0);
                 })
-                ->orWhereHas('deviceModel', function ($query) {
+                ->orWhereHas('deviceModel', function ($query): void {
                     // Only allow caching if all device models have standard dimensions (800x480, rotation=0)
-                    $query->where(function ($subQuery) {
+                    $query->where(function ($subQuery): void {
                         $subQuery->where('width', '!=', 800)
                             ->orWhere('height', '!=', 480)
                             ->orWhere('rotation', '!=', 0);

app/Services/OidcProvider.php

@@ -33,7 +33,7 @@ class OidcProvider extends AbstractProvider implements ProviderInterface
     /**
      * Create a new provider instance.
      */
-    public function __construct($request, $clientId, $clientSecret, $redirectUrl, $scopes = [], $guzzle = [])
+    public function __construct(\Illuminate\Http\Request $request, $clientId, $clientSecret, $redirectUrl, $scopes = [], $guzzle = [])
     {
         parent::__construct($request, $clientId, $clientSecret, $redirectUrl, $guzzle);
 
@@ -43,7 +43,7 @@ class OidcProvider extends AbstractProvider implements ProviderInterface
         }
 
         // Handle both full well-known URL and base URL
-        if (str_ends_with($endpoint, '/.well-known/openid-configuration')) {
+        if (str_ends_with((string) $endpoint, '/.well-known/openid-configuration')) {
             $this->baseUrl = str_replace('/.well-known/openid-configuration', '', $endpoint);
         } else {
             $this->baseUrl = mb_rtrim($endpoint, '/');
@@ -73,7 +73,7 @@ class OidcProvider extends AbstractProvider implements ProviderInterface
             }
 
         } catch (Exception $e) {
-            throw new Exception('Failed to load OIDC configuration: '.$e->getMessage());
+            throw new Exception('Failed to load OIDC configuration: '.$e->getMessage(), $e->getCode(), $e);
         }
     }
 

app/Services/PluginExportService.php

@@ -47,44 +47,33 @@ class PluginExportService
         $tempDirName = 'temp/'.uniqid('plugin_export_', true);
         Storage::makeDirectory($tempDirName);
         $tempDir = Storage::path($tempDirName);
-
-        try {
-            // Generate settings.yml content
-            $settings = $this->generateSettingsYaml($plugin);
-            $settingsYaml = Yaml::dump($settings, 10, 2, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK);
-            File::put($tempDir.'/settings.yml', $settingsYaml);
-
-            // Generate full template content
-            $fullTemplate = $this->generateFullTemplate($plugin);
-            $extension = $plugin->markup_language === 'liquid' ? 'liquid' : 'blade.php';
-            File::put($tempDir.'/full.'.$extension, $fullTemplate);
-
-            // Generate shared.liquid if needed (for liquid templates)
-            if ($plugin->markup_language === 'liquid') {
-                $sharedTemplate = $this->generateSharedTemplate($plugin);
-                if ($sharedTemplate) {
-                    File::put($tempDir.'/shared.liquid', $sharedTemplate);
-                }
+        // Generate settings.yml content
+        $settings = $this->generateSettingsYaml($plugin);
+        $settingsYaml = Yaml::dump($settings, 10, 2, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK);
+        File::put($tempDir.'/settings.yml', $settingsYaml);
+        // Generate full template content
+        $fullTemplate = $this->generateFullTemplate($plugin);
+        $extension = $plugin->markup_language === 'liquid' ? 'liquid' : 'blade.php';
+        File::put($tempDir.'/full.'.$extension, $fullTemplate);
+        // Generate shared.liquid if needed (for liquid templates)
+        if ($plugin->markup_language === 'liquid') {
+            $sharedTemplate = $this->generateSharedTemplate();
+            if ($sharedTemplate) {
+                File::put($tempDir.'/shared.liquid', $sharedTemplate);
             }
-
-            // Create ZIP file
-            $zipPath = $tempDir.'/plugin_'.$plugin->trmnlp_id.'.zip';
-            $zip = new ZipArchive();
-
-            if ($zip->open($zipPath, ZipArchive::CREATE) !== true) {
-                throw new Exception('Could not create ZIP file.');
-            }
-
-            // Add files directly to ZIP root
-            $this->addDirectoryToZip($zip, $tempDir, '');
-            $zip->close();
-
-            // Return the ZIP file as a download response
-            return response()->download($zipPath, 'plugin_'.$plugin->trmnlp_id.'.zip');
-
-        } catch (Exception $e) {
-            throw $e;
         }
+        // Create ZIP file
+        $zipPath = $tempDir.'/plugin_'.$plugin->trmnlp_id.'.zip';
+        $zip = new ZipArchive();
+        if ($zip->open($zipPath, ZipArchive::CREATE) !== true) {
+            throw new Exception('Could not create ZIP file.');
+        }
+        // Add files directly to ZIP root
+        $this->addDirectoryToZip($zip, $tempDir, '');
+        $zip->close();
+
+        // Return the ZIP file as a download response
+        return response()->download($zipPath, 'plugin_'.$plugin->trmnlp_id.'.zip');
     }
 
     /**
@@ -150,7 +139,7 @@ class PluginExportService
     /**
      * Generate the shared template content (for liquid templates)
      */
-    private function generateSharedTemplate(Plugin $plugin)
+    private function generateSharedTemplate(): null
     {
         // For now, we don't have a way to store shared templates separately
         // TODO - add support for shared templates
@@ -170,14 +159,10 @@ class PluginExportService
         foreach ($files as $file) {
             if (! $file->isDir()) {
                 $filePath = $file->getRealPath();
-                $fileName = basename($filePath);
+                $fileName = basename((string) $filePath);
 
                 // For root directory, just use the filename
-                if ($zipPath === '') {
-                    $relativePath = $fileName;
-                } else {
-                    $relativePath = $zipPath.'/'.mb_substr($filePath, mb_strlen($dirPath) + 1);
-                }
+                $relativePath = $zipPath === '' ? $fileName : $zipPath.'/'.mb_substr((string) $filePath, mb_strlen($dirPath) + 1);
 
                 $zip->addFile($filePath, $relativePath);
             }

app/Services/PluginImportService.php

@@ -72,7 +72,7 @@ class PluginImportService
 
             // Check if the file ends with .liquid to set markup language
             $markupLanguage = 'blade';
-            if (pathinfo($filePaths['fullLiquidPath'], PATHINFO_EXTENSION) === 'liquid') {
+            if (pathinfo((string) $filePaths['fullLiquidPath'], PATHINFO_EXTENSION) === 'liquid') {
                 $markupLanguage = 'liquid';
             }
 
@@ -197,7 +197,7 @@ class PluginImportService
 
             // Check if the file ends with .liquid to set markup language
             $markupLanguage = 'blade';
-            if (pathinfo($filePaths['fullLiquidPath'], PATHINFO_EXTENSION) === 'liquid') {
+            if (pathinfo((string) $filePaths['fullLiquidPath'], PATHINFO_EXTENSION) === 'liquid') {
                 $markupLanguage = 'liquid';
             }
 
@@ -352,7 +352,7 @@ class PluginImportService
             // check if they're in the root of the ZIP or in a subfolder
             if ($settingsYamlPath && $fullLiquidPath) {
                 // If the files are in the root of the ZIP, create a src folder and move them there
-                $srcDir = dirname($settingsYamlPath);
+                $srcDir = dirname((string) $settingsYamlPath);
 
                 // If the parent directory is not named 'src', create a src directory
                 if (basename($srcDir) !== 'src') {