mkrieger/byos_laravel
1
0
Fork 0
mirror of https://github.com/usetrmnl/byos_laravel.git synced 2026-01-16 16:37:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

chore: phpstan fixes, rector

Browse source
This commit is contained in:
Benjamin Nussbaum 2026-01-15 13:14:50 +01:00
parent d19a079b8a
commit b097b0a7d7
7 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/Services/ImageGenerationService.php
View file

@ -61,9 +61,9 @@ class ImageGenerationService
try {
// Get image generation settings from DeviceModel or Device (for legacy devices)
$imageSettings = $deviceModel
$imageSettings = $deviceModel instanceof DeviceModel
? self::getImageSettingsFromModel($deviceModel)
: ($device ? self::getImageSettings($device) : self::getImageSettingsFromModel(null));
: ($device instanceof Device ? self::getImageSettings($device) : self::getImageSettingsFromModel(null));
$fileExtension = $imageSettings['mime_type'] === 'image/bmp' ? 'bmp' : 'png';
$outputPath = Storage::disk('public')->path('/images/generated/'.$uuid.'.'.$fileExtension);
@ -78,7 +78,7 @@ class ImageGenerationService
$browserStage->html($markup);
// Set timezone from user or fall back to app timezone
$timezone = $user?->timezone ?? config('app.timezone');
$timezone = $user->timezone ?? config('app.timezone');
$browserStage->timezone($timezone);
if (config('app.puppeteer_window_size_strategy') === 'v2') {
@ -186,7 +186,7 @@ class ImageGenerationService
*/
private static function getImageSettingsFromModel(?DeviceModel $deviceModel): array
{
if ($deviceModel) {
if ($deviceModel instanceof DeviceModel) {
return [
'width' => $deviceModel->width,
'height' => $deviceModel->height,

8
app/Services/PluginImportService.php
View file

@ -33,11 +33,11 @@ class PluginImportService
foreach ($settings['custom_fields'] as $field) {
if (isset($field['field_type']) && $field['field_type'] === 'multi_string') {
if (isset($field['default']) && str_contains($field['default'], ',')) {
if (isset($field['default']) && str_contains((string) $field['default'], ',')) {
throw new Exception("Validation Error: The default value for multistring fields like `{$field['keyname']}` cannot contain commas.");
}
if (isset($field['placeholder']) && str_contains($field['placeholder'], ',')) {
if (isset($field['placeholder']) && str_contains((string) $field['placeholder'], ',')) {
throw new Exception("Validation Error: The placeholder value for multistring fields like `{$field['keyname']}` cannot contain commas.");
}
@ -159,7 +159,7 @@ class PluginImportService
: null,
'polling_body' => $settings['polling_body'] ?? null,
'markup_language' => $markupLanguage,
'render_markup' => $fullLiquid,
'render_markup' => $fullLiquid ?? null,
'configuration_template' => $configurationTemplate,
'data_payload' => json_decode($settings['static_data'] ?? '{}', true),
]);
@ -321,7 +321,7 @@ class PluginImportService
: null,
'polling_body' => $settings['polling_body'] ?? null,
'markup_language' => $markupLanguage,
'render_markup' => $fullLiquid,
'render_markup' => $fullLiquid ?? null,
'configuration_template' => $configurationTemplate,
'data_payload' => json_decode($settings['static_data'] ?? '{}', true),
'preferred_renderer' => $preferredRenderer,