Add image caching for playlist items

Move current_image caching to plugins

Remove redundant check

Add test for plugin cache

Skip puppeteer on GH actions

app/Jobs/CommonFunctions.php

@@ -0,0 +1,81 @@
+<?php
+
+namespace App\Jobs;
+
+use App\Models\Device;
+use App\Models\Plugin;
+use Illuminate\Support\Facades\Storage;
+use Ramsey\Uuid\Uuid;
+use Spatie\Browsershot\Browsershot;
+use Wnx\SidecarBrowsershot\BrowsershotLambda;
+
+class CommonFunctions
+{
+    public static function generateImage(string $markup): string {
+        $uuid = Uuid::uuid4()->toString();
+        $pngPath = Storage::disk('public')->path('/images/generated/'.$uuid.'.png');
+        $bmpPath = Storage::disk('public')->path('/images/generated/'.$uuid.'.bmp');
+
+        // Generate PNG
+        if (config('app.puppeteer_mode') === 'sidecar-aws') {
+            try {
+                BrowsershotLambda::html($markup)
+                    ->windowSize($device->width ?? 800, $device->height ?? 480)
+                    ->save($pngPath);
+            } catch (\Exception $e) {
+                throw new \RuntimeException('Failed to generate PNG: '.$e->getMessage(), 0, $e);
+            }
+        } else {
+            try {
+                Browsershot::html($markup)
+                    ->setOption('args', config('app.puppeteer_docker') ? ['--no-sandbox', '--disable-setuid-sandbox', '--disable-gpu'] : [])
+                    ->windowSize($device->width ?? 800, $device->height ?? 480)
+                    ->save($pngPath);
+            } catch (\Exception $e) {
+                throw new \RuntimeException('Failed to generate PNG: '.$e->getMessage(), 0, $e);
+            }
+        }
+
+        try {
+            CommonFunctions::convertToBmpImageMagick($pngPath, $bmpPath);
+        } catch (\ImagickException $e) {
+            throw new \RuntimeException('Failed to convert image to BMP: '.$e->getMessage(), 0, $e);
+        }
+        return $uuid;
+    }
+
+    /**
+     * @throws \ImagickException
+     */
+    private static function convertToBmpImageMagick(string $pngPath, string $bmpPath): void
+    {
+        $imagick = new \Imagick($pngPath);
+        $imagick->setImageType(\Imagick::IMGTYPE_GRAYSCALE);
+        $imagick->quantizeImage(2, \Imagick::COLORSPACE_GRAY, 0, true, false);
+        $imagick->setImageDepth(1);
+        $imagick->stripImage();
+        $imagick->setFormat('BMP3');
+        $imagick->writeImage($bmpPath);
+        $imagick->clear();
+    }
+
+    public static function cleanupFolder(): void
+    {
+        $activeDeviceImageUuids = Device::pluck('current_screen_image')->filter()->toArray();
+        $activePluginImageUuids = Plugin::pluck('current_image')->filter()->toArray();
+        $activeImageUuids = array_merge($activeDeviceImageUuids, $activePluginImageUuids);
+
+        $files = Storage::disk('public')->files('/images/generated/');
+        foreach ($files as $file) {
+            if (basename($file) === '.gitignore') {
+                continue;
+            }
+            // Get filename without path and extension
+            $fileUuid = pathinfo($file, PATHINFO_FILENAME);
+            // If the UUID is not in use by any device, move it to archive
+            if (! in_array($fileUuid, $activeImageUuids)) {
+                Storage::disk('public')->delete($file);
+            }
+        }
+    }
+}

app/Jobs/GeneratePluginJob.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace App\Jobs;
+
+use App\Models\Plugin;
+use Illuminate\Bus\Queueable;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Queue\InteractsWithQueue;
+use Illuminate\Queue\SerializesModels;
+
+class GeneratePluginJob implements ShouldQueue
+{
+    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+
+    /**
+     * Create a new job instance.
+     */
+    public function __construct(
+        private readonly int $pluginId,
+        private readonly string $markup
+    ) {}
+
+    /**
+     * Execute the job.
+     */
+    public function handle(): void
+    {
+        $newImageUuid = CommonFunctions::generateImage($this->markup);
+
+        Plugin::find($this->pluginId)->update(['current_image' => $newImageUuid]);
+        \Log::info("Plugin $this->pluginId: updated with new image: $newImageUuid");
+
+        CommonFunctions::cleanupFolder();
+    }
+}
+

app/Jobs/GenerateScreenJob.php

@@ -8,10 +8,6 @@ use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
-use Illuminate\Support\Facades\Storage;
-use Ramsey\Uuid\Uuid;
-use Spatie\Browsershot\Browsershot;
-use Wnx\SidecarBrowsershot\BrowsershotLambda;
 
 class GenerateScreenJob implements ShouldQueue
 {
@@ -30,72 +26,11 @@ class GenerateScreenJob implements ShouldQueue
      */
     public function handle(): void
     {
-        $device = Device::find($this->deviceId);
-        $uuid = Uuid::uuid4()->toString();
-        $pngPath = Storage::disk('public')->path('/images/generated/'.$uuid.'.png');
-        $bmpPath = Storage::disk('public')->path('/images/generated/'.$uuid.'.bmp');
+        $newImageUuid = CommonFunctions::generateImage($this->markup);
 
-        // Generate PNG
-        if (config('app.puppeteer_mode') === 'sidecar-aws') {
-            try {
-                BrowsershotLambda::html($this->markup)
-                    ->windowSize($device->width ?? 800, $device->height ?? 480)
-                    ->save($pngPath);
-            } catch (\Exception $e) {
-                throw new \RuntimeException('Failed to generate PNG: '.$e->getMessage(), 0, $e);
-            }
-        } else {
-            try {
-                Browsershot::html($this->markup)
-                    ->setOption('args', config('app.puppeteer_docker') ? ['--no-sandbox', '--disable-setuid-sandbox', '--disable-gpu'] : [])
-                    ->windowSize($device->width ?? 800, $device->height ?? 480)
-                    ->save($pngPath);
-            } catch (\Exception $e) {
-                throw new \RuntimeException('Failed to generate PNG: '.$e->getMessage(), 0, $e);
-            }
-        }
+        Device::find($this->deviceId)->update(['current_screen_image' => $newImageUuid]);
+        \Log::info("Device $this->deviceId: updated with new image: $newImageUuid");
 
-        try {
-            $this->convertToBmpImageMagick($pngPath, $bmpPath);
-        } catch (\ImagickException $e) {
-            throw new \RuntimeException('Failed to convert image to BMP: '.$e->getMessage(), 0, $e);
-        }
-        $device->update(['current_screen_image' => $uuid]);
-        \Log::info("Device $this->deviceId: updated with new image: $uuid");
-
-        $this->cleanupFolder();
-    }
-
-    /**
-     * @throws \ImagickException
-     */
-    private function convertToBmpImageMagick(string $pngPath, string $bmpPath): void
-    {
-        $imagick = new \Imagick($pngPath);
-        $imagick->setImageType(\Imagick::IMGTYPE_GRAYSCALE);
-        $imagick->quantizeImage(2, \Imagick::COLORSPACE_GRAY, 0, true, false);
-        $imagick->setImageDepth(1);
-        $imagick->stripImage();
-        $imagick->setFormat('BMP3');
-        $imagick->writeImage($bmpPath);
-        $imagick->clear();
-    }
-
-    private function cleanupFolder(): void
-    {
-        $activeImageUuids = Device::pluck('current_screen_image')->filter()->toArray();
-
-        $files = Storage::disk('public')->files('/images/generated/');
-        foreach ($files as $file) {
-            if (basename($file) === '.gitignore') {
-                continue;
-            }
-            // Get filename without path and extension
-            $fileUuid = pathinfo($file, PATHINFO_FILENAME);
-            // If the UUID is not in use by any device, move it to archive
-            if (! in_array($fileUuid, $activeImageUuids)) {
-                Storage::disk('public')->delete($file);
-            }
-        }
+        CommonFunctions::cleanupFolder();
     }
 }

app/Models/Plugin.php

@@ -17,6 +17,7 @@ class Plugin extends Model
         'data_payload' => 'json',
         'data_payload_updated_at' => 'datetime',
         'is_native' => 'boolean',
+        'current_image' => 'string',
     ];
 
     protected static function boot()