mkrieger/byos_laravel
1
0
Fork 0
mirror of https://github.com/usetrmnl/byos_laravel.git synced 2026-01-13 15:07:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(#80): display endpoint respects preferred bmp image format

Browse source
This commit is contained in:
Benjamin Nussbaum 2025-08-18 17:53:05 +02:00
parent 4e3b47e4eb
commit 2ed3fd5ca9
3 changed files with 144 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

32
tests/Feature/ImageGenerationServiceTest.php
View file

@ -423,3 +423,35 @@ it('determines correct image format from device model', function (): void {
expect($device3->current_screen_image)->toBe($uuid3);
Storage::disk('public')->assertExists("/images/generated/{$uuid3}.png");
})->skipOnGitHubActions();
it('generates BMP for legacy device with bmp3_1bit_srgb format', function (): void {
// Create a device with BMP format but no DeviceModel (legacy behavior)
$device = Device::factory()->create([
'width' => 800,
'height' => 480,
'rotate' => 0,
'image_format' => ImageFormat::BMP3_1BIT_SRGB->value,
'device_model_id' => null, // Explicitly no DeviceModel
]);
$markup = '<div style="background: white; color: black; padding: 20px;">Test Content</div>';
$uuid = ImageGenerationService::generateImage($markup, $device->id);
// Assert the device was updated with a new image UUID
$device->refresh();
expect($device->current_screen_image)->toBe($uuid);
// Assert BMP file was created
Storage::disk('public')->assertExists("/images/generated/{$uuid}.bmp");
// Verify the BMP file has content and isn't blank
$imagePath = Storage::disk('public')->path("/images/generated/{$uuid}.bmp");
$imageSize = filesize($imagePath);
expect($imageSize)->toBeGreaterThan(100); // Should be at least 100 bytes for a BMP
// Verify it's a valid BMP file
$imageInfo = getimagesize($imagePath);
expect($imageInfo[0])->toBe(800); // Width
expect($imageInfo[1])->toBe(480); // Height
expect($imageInfo[2])->toBe(IMAGETYPE_BMP); // BMP type
})->skipOnGitHubActions();