mkrieger/byos_laravel
1
0
Fork 0
mirror of https://github.com/usetrmnl/byos_laravel.git synced 2026-01-13 15:07:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(#80): display endpoint respects preferred bmp image format

Browse source
This commit is contained in:
Benjamin Nussbaum 2025-08-18 17:53:05 +02:00
parent 4e3b47e4eb
commit 2ed3fd5ca9
3 changed files with 144 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

74
tests/Feature/Api/DeviceImageFormatTest.php
View file

@ -1,6 +1,11 @@
<?php
use App\Enums\ImageFormat;
use App\Models\Device;
use App\Models\Playlist;
use App\Models\PlaylistItem;
use App\Models\Plugin;
use App\Models\User;
use Illuminate\Support\Facades\Storage;
uses(Illuminate\Foundation\Testing\RefreshDatabase::class);
@ -118,3 +123,72 @@ test('device falls back to bmp when png does not exist', function () {
'filename' => 'test-image.bmp',
]);
});
test('device without device_model_id and image_format bmp3_1bit_srgb returns bmp when plugin is rendered', function () {
// Create a user with auto-assign enabled
$user = User::factory()->create([
'assign_new_devices' => true,
]);
// Create a device without device_model_id and with bmp3_1bit_srgb format
$device = Device::factory()->create([
'user_id' => $user->id,
'mac_address' => '00:11:22:33:44:55',
'api_key' => 'test-api-key',
'device_model_id' => null, // Explicitly set to null
'image_format' => ImageFormat::BMP3_1BIT_SRGB->value,
'last_firmware_version' => '1.5.2',
]);
// Create a plugin
$plugin = Plugin::factory()->create([
'user_id' => $user->id,
'name' => 'Test Plugin',
'render_markup' => '<div>Test Content</div>',
'data_strategy' => 'static',
'markup_language' => 'blade',
'current_image' => 'test-generated-image', // Set current image directly
]);
// Create a playlist for the device
$playlist = Playlist::factory()->create([
'device_id' => $device->id,
'is_active' => true,
'refresh_time' => 900,
]);
// Create a playlist item with the plugin
$playlistItem = PlaylistItem::factory()->create([
'playlist_id' => $playlist->id,
'plugin_id' => $plugin->id,
'is_active' => true,
'order' => 1,
]);
// Mock the image generation to create both bmp and png files
$imageUuid = 'test-generated-image';
Storage::disk('public')->put('images/generated/'.$imageUuid.'.bmp', 'fake bmp content');
Storage::disk('public')->put('images/generated/'.$imageUuid.'.png', 'fake png content');
// Set the device's current screen image to the plugin's image
$device->update(['current_screen_image' => $imageUuid]);
// Test /api/display endpoint
$displayResponse = $this->withHeaders([
'id' => $device->mac_address,
'access-token' => $device->api_key,
'rssi' => -70,
'battery_voltage' => 3.8,
'fw-version' => '1.5.2',
])->get('/api/current_screen');
$displayResponse->assertOk();
$displayResponse->assertJson([
'filename' => $imageUuid.'.bmp',
]);
// Verify that the device's image_format is correctly set
$device->refresh();
expect($device->image_format)->toBe(ImageFormat::BMP3_1BIT_SRGB->value)
->and($device->device_model_id)->toBeNull();
});