mkrieger/byos_laravel
1
0
Fork 0
mirror of https://github.com/usetrmnl/byos_laravel.git synced 2026-01-13 23:18:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Wrapping text in json object with 'data' as key
Some checks failed
tests / ci (push) Has been cancelled
Details

Browse source
This commit is contained in:
kwlo 2025-11-03 21:58:36 -05:00 • committed by Benjamin Nussbaum
parent 52dfe92054
commit 10b53c3772
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/Models/Plugin.php
View file

@ -243,7 +243,7 @@ class Plugin extends Model
} }
// Response doesn't seem to be JSON, wrap the response body text as a JSON object // Response doesn't seem to be JSON, wrap the response body text as a JSON object
return ['text' => $httpResponse->body()]; return ['data' => $httpResponse->body()];
} catch (Exception $e) { } catch (Exception $e) {
Log::warning('Failed to parse JSON response: '.$e->getMessage()); Log::warning('Failed to parse JSON response: '.$e->getMessage());

2
tests/Feature/PluginXmlResponseTest.php
View file

@ -113,7 +113,7 @@ test('plugin wraps plain text response body as JSON', function (): void {
$plugin->refresh(); $plugin->refresh();
expect($plugin->data_payload)->toBe([ expect($plugin->data_payload)->toBe([
'text' => 'Lorem ipsum dolor sit amet', 'data' => 'Lorem ipsum dolor sit amet',
]); ]);
}); });